Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControlPlanes: remove scheduled and add healthy condition #97

Merged
merged 2 commits into from
Jul 9, 2024
Merged

ControlPlanes: remove scheduled and add healthy condition #97

merged 2 commits into from
Jul 9, 2024

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Jul 3, 2024 •
edited
Loading

Description of your changes

As part of the Spaces control plane provisioning improvements, this PR makes the following changes:

  • Removes Scheduled condition type
  • Adds Healthy condition type
  • Adds ControlPlaneProvisioned condition type
  • Adds status.message field to communicate a user friendly message about the provisioning (replacing the existing internal.spaces.upbound.io/message annotation
  • Updates print columns accordingly

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Together with the relevant Spaces PR:

❯ kubectl get ctp -w
NAME   CROSSPLANE    READY   HEALTHY   MESSAGE   AGE
ctp    1.15.3-up.1                               3s
ctp    1.15.3-up.1   False   False     Waiting for control plane API   6s
ctp    1.15.3-up.1   False   False     Waiting for Crossplane pods to be ready   60s
ctp    1.15.3-up.1   True    False     Waiting for Crossplane pods to be ready   65s
ctp    1.15.3-up.1   True    False     Control plane is Ready but not Healthy    69s
ctp    1.15.3-up.1   True    False     Control plane is Ready but not Healthy    74s
ctp    1.15.3-up.1   True    False     Control plane is Ready but not Healthy    80s
ctp    1.15.3-up.1   True    True                                                85s

turkenh
turkenh commented Jul 5, 2024
View reviewed changes
apis/spaces/v1beta1/conditions.go
ReasonUnhealthy xpcommonv1.ConditionReason = "UnhealthyControlPlane"

// ControlPlaneProvisioned indicates that the control plane is provisioned.
ConditionTypeControlPlaneProvisioned xpcommonv1.ConditionType = "ControlPlaneProvisioned"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super happy with the name of this condition, open for suggestions.

This will basically indicate that we are done with deploying stuff that goes into control plane, some example, crossplane, some crds, some roles for external controllers.

@turkenh turkenh force-pushed the control-plane-health branch from 7fe1424 to c872138 Compare July 5, 2024 13:49
phisco
phisco approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the suggested godoc for the Message field, LGTM 🎉 :shipit:

@turkenh turkenh force-pushed the control-plane-health branch from c872138 to 6140cf0 Compare July 8, 2024 14:19
@turkenh turkenh merged commit 18b950d into upbound:main Jul 9, 2024
5 checks passed
@turkenh turkenh deleted the control-plane-health branch July 9, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negz negz negz left review comments

@phisco phisco phisco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turkenh @negz @phisco